Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to drag-and-drop history items into the content selector #3871

Merged
merged 14 commits into from Apr 5, 2017

Conversation

Projects
None yet
4 participants
@guerler
Copy link
Contributor

commented Apr 5, 2017

Enhancement towards #3833. This does not yet allow to pick and drag sub-datasets from within collections.

drag-and-drop

@nekrut

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2017

Should also be able (reverentially) to drag and drop collections

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2017

Just to clarify this, so collections can be dragged and dropped but not datasets from within collections. Basically everything what currently can be selected with the content selector can also be dropped into it.

@nekrut

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2017

Hmmm....without being ideological I must say that dragging individual dataset from collection may be exactly what I'm asking in #3870 Why not?

@nekrut

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2017

...but the difficulty may be with workflow representations and other such things (what would happen if I would convert a history in which datasets are pulled from a collection into a workflow?). I would just make collections drag-able at this point. Need more feedback from @jmchilton and @jxtx

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2017

I totally agree with you, accessing individual components of collections would significantly improve the user experience. This PR simply filters the dropped items by dataset ids currently available in the data selector. The ids of collection datasets are not in this list. We have a couple ideas on how to extend this dynamically and make individual collection datasets selectable but that should probably not be part of this PR.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Apr 5, 2017

Great job - I really like this! I do think it is a step in the right direction and I'm excited to see follow up steps. I do think this has some advantages over #3870 as discussed on #740 but drag and drop isn't a silver bullet either - just a very common sense thing that we should definitely be doing. There are ramifications for workflow extraction say - but I think it would be happy to take a swing at solving those after dragging and dropping collection elements works.

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 5, 2017

Great stuff & very clear, also way shorter than I expected this to be.

@martenson martenson merged commit 6251b51 into galaxyproject:dev Apr 5, 2017

5 checks passed

api test Build finished. 274 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 28 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Apr 5, 2017

This was marked WIP.

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 5, 2017

Sorry for missing the wip tag, the merge was reverted with the PR above. Now I think you need to open a new PR @guerler - sorry again. :(

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2017

No worries, it was good to go. I'll open a new PR in a few and run a couple more tests. Thanks a lot for the quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.