Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small selenium hack to fix occasionally failing collection upload tests. #3967

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Apr 24, 2017

Maybe anyway... it doesn't fail locally for me.

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

@jmchilton reviewable?

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2017

@martenson Yes.

I'm wondering if I should target the Selenium tests at a jmchilton branch and aggregate a bunch of changes at once. It could reduce the strain on reviewers.

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

strain is low, I just merge it unless I see something obvious

@martenson martenson merged commit 2f518e5 into galaxyproject:dev Apr 25, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Build finished. 274 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.