Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance filenames with collection context when downloading datasets from GUI. #3985

Merged
merged 2 commits into from
May 2, 2017
Merged

Enhance filenames with collection context when downloading datasets from GUI. #3985

merged 2 commits into from
May 2, 2017

Commits on May 2, 2017

  1. Enhance filenames with collection context when downloading datasets f… 

    …rom GUI.

- Reduce duplication related to calculating filename.
- Formalized pattern for normal dataset download using string.Tempalte - "Galaxy${hid}-[${name}].${ext}".
- In the context of collections, hid and name of the datasets are pretty worthless so I used a second pattern for collections based on where it is in the current GUI frame. The new pattern is "Galaxy${hdca_hid}-[${hdca_name}__${element_identifier}].${ext}".
- The patterns make this a little more tweakable - for people who want something different it should be pretty straight forward to make these patterns configurable.

Fixes galaxyproject#2140 I think.
    @jmchilton
    jmchilton committed May 2, 2017
    Configuration menu
    Copy the full SHA
    86ebe28 View commit details
    Browse the repository at this point in the history

  2. Repack client.

    @jmchilton
    jmchilton committed May 2, 2017
    Configuration menu
    Copy the full SHA
    ef92904 View commit details
    Browse the repository at this point in the history