Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Fix destructive tag rerender to be a simpler, more precise html replacement. #4052

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented May 10, 2017

Left the original template/render in place, we could refactor as this becomes more standardized and used with other items.

@nekrut This should fix #3923, where the root problem was actually not that it was the 'first' dataset, but that it was a dataset which had had tags added to it manually.

Fix destructive tag rerender to be a simple replacement. Left the ori…
…ginal template/render in place, we could refactor as this becomes more standardized.

@nekrut nekrut requested a review from jmchilton May 11, 2017

@jmchilton jmchilton merged commit 650691c into galaxyproject:release_17.05 May 11, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

commented May 11, 2017

This PR was merged without a milestone attached.

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 11, 2017

Thanks @jmchilton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.