Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.05] Change to only inheriting 'name' tags #4104

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented May 23, 2017

We may want to branch this out further in the future, but we'll start conservatively.

Change to only inheriting 'name' tags -- we may want to branch this o…
…ut further in the future, but we'll start conservatively.

@galaxybot galaxybot added the triage label May 23, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

Fixes #4099, forgot to PR this at SAB.

@dannon dannon changed the title Change to only inheriting 'name' tags -- we may want to branch this o… [17.05] Change to only inheriting 'name' tags May 23, 2017

@dannon dannon added this to the 17.05 milestone May 23, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented May 23, 2017

I am confused here, I thought we are going to use # as the prefix for propagating (and dataset-shown) tags. Did this change back? This PR propagates only name:whatever tags.

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

# tags are name:whatever tags.

@nekrut

This comment has been minimized.

Copy link
Contributor

commented May 23, 2017

# is a shortcut for name:

@martenson

This comment has been minimized.

Copy link
Member

commented May 23, 2017

@dannon this is not clear to me, how is the hashtag supposed to work?

BEFORE
screenshot 2017-05-23 12 37 27

AFTER
screenshot 2017-05-23 12 38 23

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

Yeah, sorry, I wasn't clear. #3979 implemented hashtags as clientside shorthand -- the underlying data representation never changed.

@martenson

This comment has been minimized.

Copy link
Member

commented May 23, 2017

@dannon my point is that propagation of #hashtag does not work on this PR

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

If you're just checking out the branch and trying hashtags, it's because the change in this PR predates hashtags (I wrote it at SAB, we just never PR'd it). So, this branch does not contain all the hashtag stuff (it's irrelevant here).

To test it with hashtags, you'd probably want to check out a testing branch, merge this in, and run that.

@martenson

This comment has been minimized.

Copy link
Member

commented May 23, 2017

@dannon That explains my confusion.

After merging this with 17.05 the propagation works as expected. Minor issue is that it renames the name:huhu to #huhu in the output dataset tag - is that expected?

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

No worries. It shouldn't actually be changing it, just rendering differently. If you reload the whole page, all name:huhu should be #huhu -- can you test that?

@martenson

This comment has been minimized.

Copy link
Member

commented May 23, 2017

@dannon that seems to work, given that we won't encourage people to actually use name: notation this shouldn't cause confusion.

@martenson martenson merged commit aa8aafb into galaxyproject:release_17.05 May 23, 2017

5 checks passed

api test Build finished. 275 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.