Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap the deprecated unescape() for decodeURIComponent #4321

Merged
merged 1 commit into from Jul 17, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/galaxy/scripts/apps/analysis.js
Expand Up @@ -206,7 +206,7 @@ window.app = function app( options, bootstrapped ){
/** load the center panel with a tool form described by the given params obj */
_loadToolForm : function( params ){
//TODO: load tool form code async
params.id = unescape( params.tool_id );
params.id = decodeURIComponent( params.tool_id );
this.page.display( new ToolForm.View( params ) );
},

Expand Down
6 changes: 3 additions & 3 deletions static/scripts/bundled/analysis.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/analysis.bundled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/libs.bundled.js.map

Large diffs are not rendered by default.