Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix md5sum/sha256 in toolshed action #444

Merged
merged 7 commits into from
Jul 14, 2015
Merged

Conversation

yhoogstrate
Copy link
Member

No description provided.

@hexylena hexylena self-assigned this Jul 8, 2015
@hexylena
Copy link
Member

hexylena commented Jul 8, 2015

xref galaxy-iuc/standards#14

@hexylena
Copy link
Member

hexylena commented Jul 8, 2015

Made a PR upstream yhoogstrate#4 regarding backwards compat, if that gets merged I'm 👍 on this.

actions other than download_by_url, these must be specified as
attributes on the <action> tag, the old `#hash#` method in the URL is
not supported.
@natefoo
Copy link
Member

natefoo commented Jul 13, 2015

I've added to yhoogstrate#4, @erasche feel free to add those commits to your PR if you please, or I can PR against yours (but the levels of PR indirection are becoming unwieldy).

@hexylena
Copy link
Member

@natefoo, I'll give you access to my fork, would you mind just merging into that branch? I'm out of the office until wednesday.

@natefoo
Copy link
Member

natefoo commented Jul 13, 2015

@erasche will do.

Update docs, re-instate backwards compatability
jmchilton added a commit that referenced this pull request Jul 14, 2015
Fix md5sum/sha256 in toolshed action
@jmchilton jmchilton merged commit 1419804 into galaxyproject:dev Jul 14, 2015
@jmchilton
Copy link
Member

Thanks for the team work everyone - this seems like a really nice enhancement!

hexylena pushed a commit to galaxyproject/tools-iuc that referenced this pull request Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants