Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the robustness of Selenium workflow management tests. #4564

Merged
merged 1 commit into from Sep 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/galaxy_selenium/navigates_galaxy.py
Expand Up @@ -423,6 +423,11 @@ def workflow_index_click_search(self):
search_element.click()
return search_element

@retry_during_transitions
def workflow_index_click_import(self):
element = self.wait_for_selector_clickable(self.test_data["selectors"]["workflows"]["import_button"])
element.click()

def workflow_index_rename(self, new_name, workflow_index=0):
self.workflow_index_click_option("Rename", workflow_index=workflow_index)
alert = self.driver.switch_to.alert
Expand Down Expand Up @@ -459,6 +464,12 @@ def workflow_index_tags(self, workflow_index=0):
tags.append(tag_span.text)
return tags

def workflow_import_submit_url(self, url):
form_element = self.wait_for_selector_visible("#center form")
url_element = form_element.find_element_by_css_selector("input[type='text']")
url_element.send_keys(url)
self.click_submit(form_element)

def workflow_sharing_click_publish(self):
button = self.wait_for_selector_clickable("input[name='make_accessible_and_publish']")
button.click()
Expand Down Expand Up @@ -507,6 +518,7 @@ def click_masthead_user(self):
def click_masthead_workflow(self):
self.click_xpath(self.navigation_data["selectors"]["masthead"]["workflow"])

@retry_during_transitions
def click_button_new_workflow(self):
element = self.wait_for_selector_clickable(self.navigation_data["selectors"]["workflows"]["new_button"])
element.click()
Expand Down
8 changes: 2 additions & 6 deletions test/selenium_tests/test_workflow_management.py
Expand Up @@ -112,10 +112,6 @@ def _assert_showing_n_workflows(self, n):
self.assertEqual(len(self.workflow_index_table_elements()), n)

def _workflow_import_from_url(self):
element = self.wait_for_selector_clickable(self.test_data["selectors"]["workflows"]["import_button"])
element.click()
self.workflow_index_click_import()
url = "https://raw.githubusercontent.com/galaxyproject/galaxy/dev/test/base/data/test_workflow_1.ga"
form_element = self.driver.find_element_by_css_selector("#center form")
url_element = form_element.find_element_by_css_selector("input[type='text']")
url_element.send_keys(url)
self.click_submit(form_element)
self.workflow_import_submit_url(url)