Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Builds tests #4641

Merged
merged 4 commits into from Sep 19, 2017

Conversation

Projects
None yet
5 participants
@anatskiy
Copy link
Contributor

commented Sep 18, 2017

These simple tests test the custom builds.

for row in grid.find_elements_by_tag_name('tr'):
td = row.find_elements_by_tag_name('td')
name = td[0].text
builds.append(name)

This comment has been minimized.

Copy link
@anuprulez

anuprulez Sep 18, 2017

Member

Can we merge the lines from 83-85 into one?

builds.append(row.find_elements_by_tag_name('td')[0].text)

td and name are not being used in the method anywhere else.

@galaxybot galaxybot added the triage label Sep 18, 2017

@galaxybot galaxybot added this to the 17.09 milestone Sep 18, 2017

@jmchilton jmchilton merged commit 844f083 into galaxyproject:dev Sep 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: JavaScript No alert changes
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

Was 3 for 3 on my local box on first try - nice! Thanks @anatskiy!

@anatskiy anatskiy deleted the anatskiy:custom_builds_tests branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.