[17.09] Explicitly include PyPI as an --extra-index-url to pip #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from PyPI even when a package exists (but the correct version or architecture does not exist) on wheels.galaxyproject.org. Previously, PyPI was only checked after wheels.galaxyproject.org because pypiserver performs an automatic redirect to PyPI for any packages that do not exist in its index.
This was referenced Sep 21, 2017
Was it decided we are going to depend on wheels from PyPI instead of self hosting them? I'm not opposed I was just unaware - is there a discussion somewhere? |
|
Not formally, I believe it was discussed on Gitter. I am not opposed to hosting on wheels.galaxyproject.org either if we want, but it seems like we ought to go to the canonical source when available. |
nsoranzo
approved these changes
Sep 21, 2017
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Oct 27, 2017
Should have been part of galaxyproject#4674.
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Oct 30, 2017
Should have been part of galaxyproject#4674.
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Oct 30, 2017
Should have been part of galaxyproject#4674.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, PyPI was only checked after wheels.galaxyproject.org because pypiserver (which provides the index on wheels.galaxyproject.org) performs an automatic redirect to PyPI for any packages that do not exist in its index. It does not to the redirect if you request a specific version of a package and that package exists in pypiserver but not the requested version.
Now that we are adding dependencies to Galaxy that had old versions on wheels.galaxyproject.org but that we will install new versions of from PyPI, we need to explicitly list PyPI as an extra index when calling pip.
Wheels and source that we include in Galaxy's requirements.txt that we don't place on wheels.galaxyproject.org should be added to cargo port for archival.
Cherry picked from the branch in #4497, which will not be included in 17.09.