Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Explicitly include PyPI as an --extra-index-url to pip #4674

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
6 participants
@natefoo
Copy link
Member

commented Sep 21, 2017

Previously, PyPI was only checked after wheels.galaxyproject.org because pypiserver (which provides the index on wheels.galaxyproject.org) performs an automatic redirect to PyPI for any packages that do not exist in its index. It does not to the redirect if you request a specific version of a package and that package exists in pypiserver but not the requested version.

Now that we are adding dependencies to Galaxy that had old versions on wheels.galaxyproject.org but that we will install new versions of from PyPI, we need to explicitly list PyPI as an extra index when calling pip.

Wheels and source that we include in Galaxy's requirements.txt that we don't place on wheels.galaxyproject.org should be added to cargo port for archival.

Cherry picked from the branch in #4497, which will not be included in 17.09.

Explicitly include PyPI as an --extra-index-url to pip so we can install
from PyPI even when a package exists (but the correct version or
architecture does not exist) on wheels.galaxyproject.org. Previously,
PyPI was only checked after wheels.galaxyproject.org because pypiserver
performs an automatic redirect to PyPI for any packages that do not
exist in its index.
@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 21, 2017

Now that we are adding dependencies to Galaxy that had old versions on wheels.galaxyproject.org but that we will install new versions of from PyPI

Was it decided we are going to depend on wheels from PyPI instead of self hosting them? I'm not opposed I was just unaware - is there a discussion somewhere?

@natefoo

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

Not formally, I believe it was discussed on Gitter. I am not opposed to hosting on wheels.galaxyproject.org either if we want, but it seems like we ought to go to the canonical source when available.

@galaxybot galaxybot added the triage label Sep 21, 2017

@dannon dannon merged commit 832da6c into galaxyproject:release_17.09 Sep 21, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 17.09 milestone Sep 22, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Oct 27, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Oct 30, 2017

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.