New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataset info: present decoded IDs for admins and add peek #5006
Conversation
Record time from request to PR, thank you @martenson! |
@@ -174,11 +174,26 @@ | |||
%if job: | |||
<tr><td>Tool Exit Code:</td><td>${ job.exit_code | h }</td></tr> | |||
%endif | |||
<tr><td>History Content API ID:</td><td>${encoded_hda_id}</td></tr> | |||
<tr><td>History Content API ID:</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also change the name to indicate that it is a decoded id for the admin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this is clear for people that are actually using IDs for anything. What would you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply adding (decoded)
? If this is obvious, all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it there, but @natefoo called it superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :)
I often use this as a starting point to interact with the API. Can we toggle this instead ? |
@mvdbeek both are present |
D'oh. 👍 (I did look at the code this time). |
Do we have a plan for replicating this via the API longer term? An admin only api endpoint to decode IDS maybe? |
@jmchilton I would enhance the dict for admin using the same endpoint, is that a nono now? |
@martenson That would be fine with me I think - I just wanted to know what the plan is. |
@jmchilton I will implement that in a different PR |
ping @natefoo