Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset info: present decoded IDs for admins and add peek #5006

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
5 participants
@martenson
Copy link
Member

martenson commented Nov 14, 2017

ping @natefoo

@natefoo

This comment has been minimized.

Copy link
Member

natefoo commented Nov 14, 2017

Record time from request to PR, thank you @martenson!

@@ -174,11 +174,26 @@
%if job:
<tr><td>Tool Exit Code:</td><td>${ job.exit_code | h }</td></tr>
%endif
<tr><td>History Content API ID:</td><td>${encoded_hda_id}</td></tr>
<tr><td>History Content API ID:</td>

This comment has been minimized.

Copy link
@bgruening

bgruening Nov 14, 2017

Member

Should we also change the name to indicate that it is a decoded id for the admin?

This comment has been minimized.

Copy link
@martenson

martenson Nov 14, 2017

Author Member

I thought this is clear for people that are actually using IDs for anything. What would you suggest?

This comment has been minimized.

Copy link
@bgruening

bgruening Nov 14, 2017

Member

Simply adding (decoded)? If this is obvious, all good.

This comment has been minimized.

Copy link
@martenson

martenson Nov 14, 2017

Author Member

I had it there, but @natefoo called it superfluous.

This comment has been minimized.

Copy link
@bgruening
@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Nov 14, 2017

I often use this as a starting point to interact with the API. Can we toggle this instead ?

@martenson

This comment has been minimized.

Copy link
Member Author

martenson commented Nov 14, 2017

@mvdbeek both are present

@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Nov 14, 2017

D'oh. 👍 (I did look at the code this time).

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Nov 14, 2017

Do we have a plan for replicating this via the API longer term? An admin only api endpoint to decode IDS maybe?

@martenson

This comment has been minimized.

Copy link
Member Author

martenson commented Nov 14, 2017

@jmchilton I would enhance the dict for admin using the same endpoint, is that a nono now?

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Nov 14, 2017

@martenson That would be fine with me I think - I just wanted to know what the plan is.

@martenson

This comment has been minimized.

Copy link
Member Author

martenson commented Nov 14, 2017

@jmchilton I will implement that in a different PR

@jmchilton jmchilton merged commit 482ff77 into galaxyproject:dev Nov 15, 2017

7 checks passed

api test Build finished. 310 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the martenson:decode_for_admins branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.