New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Add ICM datatype for glimmer #5042

Merged
merged 3 commits into from Nov 28, 2017

Conversation

Projects
None yet
5 participants
@abretaud
Contributor

abretaud commented Nov 20, 2017

Hey,
Just a new little datatype needed for the update of glimmer tool in bgruening/galaxytools#660

abretaud added some commits Nov 20, 2017

@galaxybot galaxybot added the triage label Nov 20, 2017

@abretaud abretaud referenced this pull request Nov 20, 2017

Merged

Migrate Glimmer tools #1593

dataset.blurb = 'file purged from disk'
def sniff(self, dataset):
line = open(dataset).readline()

This comment has been minimized.

@bgruening

bgruening Nov 20, 2017

Member

Can we restrict how many characters we read here with .read(100) or so?

@bgruening

This comment has been minimized.

Member

bgruening commented Nov 21, 2017

Thanks @abretaud! Because this is a backport to a stable release we need to have two +1.
I'm not sure this is currently allowed, as we can probably not count it as bugfix. But let's see what others think.

@abretaud

This comment has been minimized.

Contributor

abretaud commented Nov 21, 2017

Ok we'll see, no problem to retarget if needed, I was maybe a little too optimistic!

@bgruening

This comment has been minimized.

Member

bgruening commented Nov 22, 2017

@mvdbeek could you look at it as well, please?

@bgruening bgruening added area/datatypes and removed triage labels Nov 24, 2017

@mvdbeek mvdbeek merged commit f6aedb0 into galaxyproject:release_17.09 Nov 28, 2017

7 checks passed

api test Build finished. 293 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 18.01 milestone Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment