Managers, taggable: make anon set_tags fail silently #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
dannon
added a commit
that referenced
this pull request
Jul 29, 2015
Managers, taggable: make anon set_tags fail silently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a manager attempts to set tags on an item with an anonymous user, the taggable manager would previously error.
If we attempt to copy tags when we copy hdas however, and the user doing the copying is anonymous: the copy should be doable but there is no user to associate with the tags (we can't use the original's user's tags).
An unsatisfying compromise is to fail silently when an anon user copies hdas. The hda will not have the original tags but the copy will be possible.