Allow setting tags on targets & contents in data fetch API. #6499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
changed the title
jmchilton
force-pushed
the
upload_tags_api
branch
from
09545fe
to
80ede7e
Compare
mvdbeek
reviewed
Jul 15, 2018
lib/galaxy/managers/collections.py
Outdated
| @@ -46,11 +46,11 @@ def __init__(self, app): | |||
| self.tag_manager = tags.GalaxyTagManager(app.model.context) | |||
| self.ldda_manager = lddas.LDDAManager(app) | |||
|
|
|||
| def precreate_dataset_collection_instance(self, trans, parent, name, structure, implicit_inputs=None, implicit_output_name=None): | |||
| def precreate_dataset_collection_instance(self, trans, parent, name, structure, implicit_inputs=None, implicit_output_name=None, tags=[]): | |||
There was a problem hiding this comment.
I guess we'll want to avoid tags being mutable here.
There was a problem hiding this comment.
Opps... definitely. Thanks for the catch.
Rebased with default argument handling improvements suggested by Marius.
jmchilton
force-pushed
the
upload_tags_api
branch
from
80ede7e
to
f9ba8d3
Compare
jmchilton
changed the title
|
Thanks for the typo fixes @dannon and the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend to power better metadata collection when importing large amounts of structured data - with tests.
I'll follow up with rule builder enhancements that allow setting name tags on uploaded collections and datasets with specific support for group tags, name tags, and general purpose tags.
xref #6202
xref #5822
xref #6491
xref #5457
xref #3979
xref #5462
xref Many long conversations about the future of multi-factor analyses in Galaxy at the GCC that we didn't take any notes of or create any issues out of.