Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining selenium py3 test failures #6610

Merged
merged 2 commits into from
Aug 17, 2018

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 16, 2018

Should fix

selenium.webdriver.remote.remote_connection DEBUG 2018-08-16 19:17:13,852 Finished Request
galaxy.web.framework.decorators ERROR 2018-08-16 19:17:13,858 Uncaught exception in exposed API method:
Traceback (most recent call last):
  File "/galaxy/lib/galaxy/web/framework/decorators.py", line 157, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "/galaxy/lib/galaxy/web/framework/decorators.py", line 77, in decorator
    return func(self, trans, *args, **kwargs)
  File "/galaxy/lib/galaxy/webapps/galaxy/controllers/history.py", line 317, in list
    return self.stored_list_grid(trans, **kwargs)
  File "/galaxy/lib/galaxy/web/framework/helpers/grids.py", line 139, in __call__
    query = column.filter(trans, trans.user, query, column_filter)
  File "/galaxy/lib/galaxy/web/framework/helpers/grids.py", line 664, in filter
    query = query.filter(self.get_filter(trans, user, column_filter))
  File "/galaxy/lib/galaxy/web/framework/helpers/grids.py", line 703, in get_filter
    raw_tags = trans.app.tag_handler.parse_tags(column_filter.encode("utf-8"))
  File "/galaxy/lib/galaxy/managers/tags.py", line 260, in parse_tags
    raw_tags = reg_exp.split(tag_str)
TypeError: cannot use a string pattern on a bytes-like object

xref. #1715

Should fix

```
selenium.webdriver.remote.remote_connection DEBUG 2018-08-16 19:17:13,852 Finished Request
galaxy.web.framework.decorators ERROR 2018-08-16 19:17:13,858 Uncaught exception in exposed API method:
Traceback (most recent call last):
  File "/galaxy/lib/galaxy/web/framework/decorators.py", line 157, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "/galaxy/lib/galaxy/web/framework/decorators.py", line 77, in decorator
    return func(self, trans, *args, **kwargs)
  File "/galaxy/lib/galaxy/webapps/galaxy/controllers/history.py", line 317, in list
    return self.stored_list_grid(trans, **kwargs)
  File "/galaxy/lib/galaxy/web/framework/helpers/grids.py", line 139, in __call__
    query = column.filter(trans, trans.user, query, column_filter)
  File "/galaxy/lib/galaxy/web/framework/helpers/grids.py", line 664, in filter
    query = query.filter(self.get_filter(trans, user, column_filter))
  File "/galaxy/lib/galaxy/web/framework/helpers/grids.py", line 703, in get_filter
    raw_tags = trans.app.tag_handler.parse_tags(column_filter.encode("utf-8"))
  File "/galaxy/lib/galaxy/managers/tags.py", line 260, in parse_tags
    raw_tags = reg_exp.split(tag_str)
TypeError: cannot use a string pattern on a bytes-like object
```
@mvdbeek mvdbeek changed the title Keep unicode tags Fix remaining selenium py3 test failures Aug 16, 2018
@mvdbeek mvdbeek added kind/refactoring cleanup or refactoring of existing code, no functional changes status/review area/testing/selenium labels Aug 16, 2018
@galaxybot galaxybot added this to the 18.09 milestone Aug 16, 2018
@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 17, 2018

We're down to 3 failures with python3: https://jenkins.galaxyproject.org/job/docker-selenium-py3/17/testReport/ -- 2 of these also fail on python 2. It's the generate test_generate_tour_with_data that is specific to python 3

@dannon dannon merged commit 2c69009 into galaxyproject:dev Aug 17, 2018
@nsoranzo nsoranzo deleted the fix_selenium_py3_tests branch August 17, 2018 14:21
@nsoranzo nsoranzo added the area/python3 Specific to Python 3 label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/python3 Specific to Python 3 area/testing/selenium kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants