Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #525. Repo info dicts and tsr_ids were filtered for pre-ins… #681

Merged
merged 1 commit into from Sep 2, 2015

Conversation

@mvdbeek
Copy link
Member

mvdbeek commented Sep 1, 2015

...stalled tools, but the unfiltered info_dict was passed on, causing misalignment of repository and tsr_id.

…talled tools, but the unfiltered info_dict was passed on, causing misalignment of repository and tsr_id.
@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Sep 1, 2015

@mvdbeek nice one! I was able to reproduce this with one repository.
👍

@davebx Is this something for the stable branch as well?

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Sep 2, 2015

Awesome - community patch, community review ...!
#525 (comment)

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Sep 2, 2015

@davebx @dannon I would like to get this into 15.07 if possible. Any idea how to do so?

bgruening added a commit that referenced this pull request Sep 2, 2015
Fix issue #525. Repo info dicts and tsr_ids were filtered for pre-ins…
@bgruening bgruening merged commit e584a35 into galaxyproject:dev Sep 2, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mvdbeek

This comment has been minimized.

Copy link
Member Author

mvdbeek commented Sep 2, 2015

@bgruening thanks. Also, very good testcase by @bcclaywell.
Made debugging much easier.

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Sep 2, 2015

Indeed you guys rock!

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Sep 2, 2015

@bgruening Something like:

$ cd your-galaxy-fork-repo/
$ git checkout dev
$ git pull
$ git checkout release_15.07
$ git pull
$ git cherry-pick ee46947c3d58a98d0c6640ba3eea3ef405d8c9c3
$ git push

And open a PR for 15.07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.