Fix post job actions for Database Operation tools, implement change_datatype for collection output #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
fix_build_list_pjas
branch
2 times, most recently
from
aae9020
to
670f190
Compare
|
@mvdbeek Thanks for this -- I should have added tests for these years ago, would have saved some pain! |
The rename action works, the hide action fails. Building this to fix galaxyproject#7473.
mvdbeek
force-pushed
the
fix_build_list_pjas
branch
from
670f190
to
0951324
Compare
|
Looks like it's working, but I think I'll want to test all of the possible PJAs. |
mvdbeek
added
area/UI-UX
area/workflows
area/dataset-collections
kind/bug
kind/enhancement
and removed
triage
labels
`change_datatype` wasn't part of gxformat2, so this also requires a new release of gxformat2 with galaxyproject/gxformat2#7
This fixes dataset being added to histories when the source HDA is visible.
|
This will also fix #3947. |
mvdbeek
changed the title
|
I assume we should backport this to at least 19.01? |
|
Yep, I wouldn't go further back than 19.01, it is more of a new feature than a bug I'd say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename action works, the hide action fails.
Building this to fix #7473.