Refactor galaxy.web.form_builder into galaxy.util.form_builder. #7529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
form_builder_2
branch
from
e090723
to
90753e0
Compare
We have other utilities for web content in galaxy.util like sanitize_html, so while I'm not eager to put web stuff in there it is not bringing any dependencies into galaxy's util package. The upshot here is that now model doesn't need to have dependencies on galaxy.web (other than implicitly through galaxy.managers.tags - but that really has to be refactored either way). Contains some more cleanup related to url_for (see galaxyproject#7521 for context).
jmchilton
force-pushed
the
form_builder_2
branch
from
90753e0
to
976f5ad
Compare
mvdbeek
added
kind/refactoring
mvdbeek
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have other utilities for web content in galaxy.util like sanitize_html, so while I'm not eager to put web stuff in there it is not bringing any dependencies into galaxy's util package. The upshot here is that now model doesn't need to have dependencies on galaxy.web (other than implicitly through galaxy.managers.tags - fixed in #7530).
Contains some more cleanup related to url_for (see #7521 for context).