Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy object store initialization for distribute object stores. #7768

Closed
wants to merge 2 commits into from

Conversation

jmchilton
Copy link
Member

Broken I guess with collection parameters and not really anything to do with collections - probably why we sometimes see it in the tool submission form also.

This fix should also speed up tool submission on main since the whole point was to avoid was to avoid disk access in web and scheduler threads, and this disk access snuck as part of the tool action code.

Fix #7368

@mvdbeek
Copy link
Member

mvdbeek commented Apr 19, 2019

Those errors look at least partially relevant. I also stumbled on this divergent path in the object store code a couple times before -- when calling get_filename the disk-based object stores creates and returns a path, while the distributed object stores will try all available object stores and raise an exception if the path doesn't exist. We should really unify this.

@mvdbeek
Copy link
Member

mvdbeek commented May 17, 2019

Merged as part of #7939

@mvdbeek mvdbeek closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-eager object store initialization may happen too late
3 participants