[19.05] Fix application of history default permissions to anonymous histories carried over upon login #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefoo
added
kind/bug
status/review
area/security
area/auth
|
Can we target 19.05 with this? Or we can backport, but I think it is worth it. |
carried over upon login.
natefoo
force-pushed
the
login-apply-history-permissions
branch
from
f4385a9
to
48c5b58
Compare
natefoo
changed the title
|
Retargeted to 19.05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally addressed many years ago when the behavior on login was updated in ca6ba6e. I believe the intent was to ensure that permission defaults would only be set on histories that were created while anonymous but as it was, they would only be applied to users who had no previous sessions, which would only happen on registration/creation.
Histories created upon login have their permission defaults set in the new history creation method, histories that are already owned by the user are not modified.