Datatype I/O fixes #7995
Merged
Datatype I/O fixes #7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavior changes: - Now includes a trailing new line if the input contained a trailing newline. - Now returns only as many lines as are present if the file contains fewer lines than LINE_COUNT.
- Fix bug where sep2tabs didn't work with '\r\n' - Fix bug where sep2tabs didn't work with '\r' - we were opening it with universal newlines. - Fix memory bug where convert_newlines would read unbounded buffers - other methods still do though :(. - Simplify convert_newlines to just let universal newline handling handle the conversion.
|
This is amazing @mvdbeek - thanks for saving me from this, I was really getting lost in the weeds and everything here looks amazing now. |
mvdbeek
commented
May 17, 2019
Just call convert_newlines with a compiled regex
|
I'm going to backport all of this to 19.05, some of it (e.g. ed24664 probably should go back to 19.01 also). |
Merged
jmchilton
added a commit
that referenced
this pull request
May 19, 2019
[19.05] Add missing commits from #7995 backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying a different newline replacement strategy and paramterizing unit test