Fix tool run uses ellipses slightly too soon #8018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
reviewed
May 24, 2019
| @@ -68,15 +68,15 @@ var View = Backbone.View.extend({ | |||
| ); | |||
| } else { | |||
| Galaxy.modal && | |||
There was a problem hiding this comment.
@guerler Do you remember why we needed to have this guard in here? Is it irrelevant now, and safe to drop?
There was a problem hiding this comment.
Yes, it should be safe to remove that safe guard now.
|
switching to WIPdue to #7984 (comment) |
on after-execution page
|
|
dannon
approved these changes
Jun 6, 2019
dannon
added
kind/enhancement
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7984