[WIP] Build and install wheel for packages when testing them #8358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `pip install -e` the installed packages were just links to the corresponding source code. This will highlight a number of issues with some packages.
nsoranzo
force-pushed
the
properly_test_packages
branch
from
100f8b9
to
4f2a861
Compare
|
Should we fix the packages in another PR and then merge this afterward? |
|
@natefoo Here or in another PR, same for me. I just came back from holidays, catching up with all the things, if any one has time to fix packages feel free to push to my branch, otherwise I'll work on this at some point. |
|
If you like the direction I've taken there, sure :) |
|
Closing in favour of #8480 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
pip install -ethe installed packages were just links to the corresponding source code.This will highlight a number of issues with some packages (help in fixing them welcome!).