Properly test packages, add galaxy-test-tools and galaxy-model-tools package #8480
Conversation
With `pip install -e` the installed packages were just links to the corresponding source code. This will highlight a number of issues with some packages.
mvdbeek
force-pushed
the
properly_test_packages
branch
2 times, most recently
from
1ecf289
to
00e8a4f
Compare
mvdbeek
force-pushed
the
properly_test_packages
branch
2 times, most recently
from
5ad4be7
to
c38597e
Compare
packages/app/setup.py
Outdated
| @@ -55,7 +55,7 @@ def get_var(var_name): | |||
| 'galaxy.tools.error_reports', | |||
| 'galaxy.tools.expressions', | |||
| 'galaxy.tools.filters', | |||
| 'galaxy.tools.imp_exp', | |||
| 'galaxy.model_tools.imp_exp', | |||
There was a problem hiding this comment.
| 'galaxy.model_tools.imp_exp', |
and add galaxy-model-tools to packages/app/requirements.txt
|
Fascinating... wasn't a direction I was expecting but looks good. |
|
Cool, but why "model_tools". The name is not immediately intuitive to me. |
|
No good reason, we've been calling them that way in the codebase, they're also known as Database Operation tools. We could also call them "special tools", "framework tools" or something else altogether. Do you have a suggestion ? |
|
This will break import/export jobs that occur during an upgrade I think. We broke those last cycle and no one noticed. The little we tried to do to save them just turned out to be unneeded complexity and wasted effort IMO - so I'd just like to do that one more time and keep this as is without worrying about these potential jobs. |
|
I think we may be able to rescue those jobs if we provide a fallback import at the old location -- that should be possible, right ? |
|
I mean - we could definitely fix them. I don't think it is worth adding the lines of code to do that though. It will likely not really save a job across all Galaxies everywhere IMO. |
and make them test requirements of tool_util
mvdbeek
force-pushed
the
properly_test_packages
branch
from
f7ce1f8
to
5521d14
Compare
|
Framework tools makes more sense to me.
--
jt (mobile)
|
|
😿 this was cool stuff - hopefully we find some time to keep it going at some point. |
Builds on #8358