Refactor some workflow editor plumbing to VueJS #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/enhancement
kind/refactoring
guerler
reviewed
Nov 4, 2019
client/galaxy/scripts/components/Workflow/Editor/WorkflowEditor.vue
Outdated
Show resolved
Hide resolved
- More robust CSS sizing (get rid of awful height: 95% hack). - Rework JS so component injection of markdown editor can be used. - Replace jQuery hide/show interactions for buttons, etc.. with v-show.
jmchilton
force-pushed
the
workflow_editor_vue
branch
from
adb7e5e
to
002a1a7
Compare
... sortof anyway.
jmchilton
force-pushed
the
workflow_editor_vue
branch
from
002a1a7
to
afec299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkflowViewobject in VueJS instead of in mako.