Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more repository installation test cases #9160

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Dec 22, 2019

These were supposed to not pass without
#9159, but they do.
I don't think this increases test coverage but it might be handy
to have this as integration test cases when we rip out the toolshed
from the Galaxy code base ?

@mvdbeek
Copy link
Member Author

mvdbeek commented Dec 22, 2019

oh no, first time i've seen the macro reload error back since I thought I fixed it last time :(

            tool = self.toolbox.get_tool("tool_with_macro")
            assert tool.version == "3.0"
    
>       self._try_until_no_errors(check_tool_macro)

test/unit/tools/test_toolbox.py:210: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
test/unit/tools/test_toolbox.py:255: in _try_until_no_errors
    raise e
test/unit/tools/test_toolbox.py:249: in _try_until_no_errors
    f()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    def check_tool_macro():
        tool = self.toolbox.get_tool("tool_with_macro")
>       assert tool.version == "3.0"
E       AssertionError: assert '2.0' == '3.0'
E         - 2.0
E         + 3.0

test/unit/tools/test_toolbox.py:208: AssertionError

@galaxybot galaxybot added this to the 20.05 milestone Dec 22, 2019
@jmchilton
Copy link
Member

Rebase now that baseline tests pass?

@mvdbeek mvdbeek force-pushed the additional_repository_integration_tests branch from a3f9d18 to f7b604c Compare January 9, 2020 17:03
These were supposed to not pass without
galaxyproject#9159, but they do.
I don't think this increases test coverage but it might be handy
to have this as integration test cases when we rip out the toolshed
from the Galaxy code base ?
@mvdbeek mvdbeek force-pushed the additional_repository_integration_tests branch from f7b604c to bc1013c Compare February 20, 2020 15:20
@jmchilton jmchilton merged commit 549eb35 into galaxyproject:dev Apr 20, 2020
@jmchilton
Copy link
Member

Thank you kindly - looks awesome!

@nsoranzo nsoranzo deleted the additional_repository_integration_tests branch April 20, 2020 18:25
@galaxyproject galaxyproject deleted a comment from galaxybot Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants