[20.01] Fix runtime error in ToolConfWatcher #9212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should prevent
```
Traceback (most recent call last):
File "PY3.7/threading.py", line 917, in _bootstrap_inner
self.run()
File "PY3.7/threading.py", line 865, in run
self._target(*self._args, **self._kwargs)
File "lib/galaxy/tools/toolbox/watcher.py", line 101, in check
hashes = {key: None for key in self.paths.keys()}
File "lib/galaxy/tools/toolbox/watcher.py", line 101, in <dictcomp>
hashes = {key: None for key in self.paths.keys()}
RuntimeError: dictionary changed size during iteration
```
We do something similar already in https://github.com/mvdbeek/galaxy/blob/6af20e1b0cac5a3abdcab3be901b4d0a761b9067/lib/galaxy/tools/toolbox/watcher.py#L105
nsoranzo
reviewed
Jan 13, 2020
Co-Authored-By: Marius van den Beek <m.vandenbeek@gmail.com>
nsoranzo
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent
We do something similar already in https://github.com/mvdbeek/galaxy/blob/6af20e1b0cac5a3abdcab3be901b4d0a761b9067/lib/galaxy/tools/toolbox/watcher.py#L105
reported by @selten on gitter