[20.01] Make watcher more resilient to missing files #9738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcm32
reviewed
May 7, 2020
| with open(job_state.error_file, 'w') as error_file: | ||
| error_file.write("No Kubernetes Jobs are available under expected selector app=%s\n" % job_state.job_id) | ||
| self.mark_as_failed(job_state) | ||
| try: |
There was a problem hiding this comment.
Good! this should at least avoid the missing file to derail the loop of jobs being checked.
|
Can you rebase this against the target branch? We had to force push it to correct something that had been erroneously merged. |
nsoranzo
changed the title
nuwang
force-pushed
the
k8s_runner_resilience
branch
from
f711db2
to
9a6b10e
Compare
|
@dannon Done. |
afgane
approved these changes
May 8, 2020
mvdbeek
approved these changes
May 8, 2020
afgane
added a commit
that referenced
this pull request
Feb 5, 2021
Nuwan Goonasekera (@nuwang) has been an active member of the Galaxy community for nearly a decade. He has made numerous and significant contributions across the spectrum of Galaxy Project repositories: [bioblend](https://github.com/galaxyproject/bioblend/commits?author=nuwang), [ansible-galaxy](https://github.com/galaxyproject/ansible-galaxy/commits?author=nuwang), [galaxy-helm]https://github.com/galaxyproject/galaxy-helm/commits?author=nuwang), and others. He actively helps users and other team members by answering questions via chat and issues on GitHuh, providing constructive feedback and dedicating time to follow up, eg. https://gitter.im/galaxyproject/wg-deployment?at=601ae0a655359c58bf1c8ff7, https://gitter.im/galaxyproject/FederatedGalaxy?at=6019abed428d9727dd4ebacb, CloudVE/cloudbridge#258. He has made a number of improvements to the Galaxy codebase demonstrating his grasp and commitment to the core project: - https://github.com/galaxyproject/galaxy/pulls?page=2&q=is%3Apr+author%3Anuwang The following pull requests exemplify his contributions over the years: - #10681 - #9738 - #1814 I propose we add Nuwan to the Galaxy committers group to both recognize his contributions and benefit more directly from his expertise. @galaxyproject/core please vote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve: