New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt at fixing silent failure #203

Merged
merged 1 commit into from May 13, 2015

Conversation

Projects
None yet
3 participants
@martenson
Copy link
Member

martenson commented May 13, 2015

when shed_uploading but repo does not exist on target
reported #198
+typo

attempt at fixing silent failure
when shed_uploading but repo does not exist on target
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented May 13, 2015

Thanks for the fix - looks like the Travis failures indicate the ftp parameters stuff broke Galaxy.

jmchilton added a commit that referenced this pull request May 13, 2015

Merge pull request #203 from galaxyproject/martenson-patch-1
attempt at fixing silent failure

@jmchilton jmchilton merged commit 3501358 into master May 13, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@martenson

This comment has been minimized.

Copy link
Member Author

martenson commented May 13, 2015

yeah, I did not realize you are running those tests here :)

@martenson martenson deleted the martenson-patch-1 branch May 13, 2015

martenson added a commit that referenced this pull request May 14, 2015

fix to #203
the referenced variable was not intialized
broken in  48e0ca7

jmchilton added a commit that referenced this pull request May 14, 2015

@erasche

This comment has been minimized.

Copy link
Member

erasche commented May 18, 2015

@martenson just experienced this bug, went to patch, saw that you already had. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment