New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed detection of venv in makefile #311

Merged
merged 1 commit into from Sep 30, 2015

Conversation

Projects
None yet
2 participants
@lparsons
Copy link
Contributor

lparsons commented Sep 30, 2015

The setup-venv function in the Makefile was not properly detecting the need to create a venv and thus resulted in installing all the packages in the environment that make was executed in.

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 30, 2015

Great, thanks!

jmchilton added a commit that referenced this pull request Sep 30, 2015

Merge pull request #311 from lparsons/fix_setup-venv
Fixed detection of venv in makefile

@jmchilton jmchilton merged commit 7364b39 into galaxyproject:master Sep 30, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@lparsons lparsons deleted the lparsons:fix_setup-venv branch Sep 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment