Fix PBS status reporting #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this commit only very short jobs completed successfully, because the status was always set to complete. This was because the status returned by qstat contains leading spaces before the `job_state = Q` part, so I'm adding a `.strip()`.
|
Awesome - I need a better test bed for PBS stuff clearly. This is fantastic - keep the fixes coming :). |
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Apr 18, 2016
- Fix working directory outputs for a2e3140 (giving tools clean working directories). - Fix copy action when target directory doesn't already exist (galaxyproject/pulsar#107 thanks to @natefoo). - Fix handling of Pulsar jobs that fail during submission (galaxyproject/pulsar#103 thanks to @mvdbeek). - Fix PBS status reporting (galaxyproject/pulsar#102 thanks to @mvdbeek). - Fix for JetStream that allows setting staging directories on a per-manager basis (galaxyproject/pulsar@7d40304).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this commit only very short jobs completed successfully, because the
status was always set to complete. This was because the status returned by
qstat contains leading spaces before the
job_state = Qpart, so I'm adding a.strip().