Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate session for oauth login and regular login #11

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use separate session for oauth login and regular login #11

wants to merge 1 commit into from

Conversation

trasher
Copy link
Member

@trasher trasher commented Jun 12, 2024

This way:

  • existing loggedin user won't be used and won't be logged out
  • no user will stay loggedin after oauth redirect

@trasher
Use separate session for oauth login and regular login
c1e8fde 
This way:
- existing loggedin user won't be used and won't be logged out
- no user will stay loggedin after oauth redirect
@trasher trasher marked this pull request as draft June 13, 2024 14:43
@trasher
Copy link
Member Author

trasher commented Jun 13, 2024

I put back this one to draft. Changes are OK from a technical PoV, everything was OK during my tests. But there is one major problem: flash messages are no longer displayed with that change - I've not yet been able to find a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trasher