Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in 3.4.0b6 synchrotron small scale modulation #154

Merged
merged 10 commits into from
Feb 25, 2023

Conversation

zonca
Copy link
Member

@zonca zonca commented Feb 25, 2023

Fixing bug discovered in #153

  • remove outputs
  • fix normalization of modulation maps, save with version, lower lmax
  • executed notebook
  • update filenames
  • use version in outputs
  • fix typo

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zonca
Copy link
Member Author

zonca commented Feb 25, 2023

Comparison with @giuspugl's results

It looks good, consider they are different realizations of the small scales. edit, no they are the same realization, in fact the ratio agrees to about to machine precision of 1e-8
uK_RJ

image
image
image

Ratio

Scale is (1-1e-7, 1+1e-7)

image
image
image

@zonca
Copy link
Member Author

zonca commented Feb 25, 2023

when I generate instead the templates to a higher output ell, it is like using a different realization.

so, in order to simulate that case I run the same exact notebook that gives perfect agreement before with a different seed, I get relative differences of the order of 30% in Temperature and even higher in polarization.
Spectra agree.

image

image

@zonca
Copy link
Member Author

zonca commented Feb 25, 2023

The production run, where I generate alms up to 16384, has the same level of disagreement:

image

@zonca zonca self-assigned this Feb 25, 2023
@zonca zonca merged commit 8a564ad into galsci:main Feb 25, 2023
@zonca zonca deleted the fix_sync_beta6 branch February 25, 2023 20:02
@giuspugl
Copy link
Contributor

Hi @zonca i 'd say it is consistent with my expectations. If we have higher lmax wrt the one set in my notebooks (ell=2000) then we'd see larger effects in the residuals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants