Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce edit metadata permission #239

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

fenekku
Copy link
Collaborator

@fenekku fenekku commented Jan 24, 2019

Closes #13

- Change URL of deposit page to /records/new
  More work on URLs will be needed
- Add edit button to record page
- Rename edit page URL to /records/<draft>/edit
- Rename record template record.html -> view.html
  for consistency with edit.html
- Can edit published record
- Update schema of deposit records
- Only return published record if draft published
- api.py's Deposit represents a draft or published record
  (with files) now. This is very much an enhancement of default
  data model.
- Can publish an edited record
@fenekku fenekku force-pushed the 13_record_editable_by_owner_superuser branch 2 times, most recently from 24e1006 to 3049e8e Compare January 24, 2019 21:46
- Only owner and super user can edit a record
- Establishes the permission architecture
  for the project.
- Gate the edit link from Record page
- Gate the edit page URL
Copy link
Collaborator

@sharpattack sharpattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't forget to rebase/remove the other two commits.

@fenekku fenekku merged commit d1ff623 into master Jan 29, 2019
@fenekku fenekku deleted the 13_record_editable_by_owner_superuser branch January 29, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants