-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically roll latest version tag #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
Didn't seem to work after editing the release, even though reading the triggers documentation I had expected this to work. |
Trying to fix in #30 |
Reverted in #31 Rolling next minor version instead. |
Still does not work, with the warning I also do not see a difference in unity builder's versioning workflow, just that we use a more complicated tag ( I believe 2 digit versions are quite common in actions, not sure if we should switch everything to 3 digit semantic versioning. |
I think we should use 3 digit semantic versioning everywhere, where we leave the patch version as 0 most of the time. For example, can we try |
https://www.npmjs.com/package/semver#user-content-coercion should work for us. However it is currently only done for prereleases (see here). To make it work for non-prerelease v[Major].[Minor] and deduce [Patch] we will need this. Forking the action. |
Or that. |
Since rule 2 of semantic versioning dictates that a normal version number MUST have three digits, I think your suggestion is better @davidmfinol. Let's move to full semver for all our repos to solve the problem across the board. Tagging one additional version to close this issue. |
Changes
game-ci/steam-deploy@v1
, unable to find versionv1
#27.Checklist