Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically roll latest version tag #28

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Automatically roll latest version tag #28

merged 1 commit into from
Dec 27, 2021

Conversation

davidmfinol
Copy link
Member

Changes

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@webbertakken webbertakken merged commit 0f339df into main Dec 27, 2021
@webbertakken webbertakken deleted the versioning branch December 27, 2021 16:36
@webbertakken
Copy link
Member

Didn't seem to work after editing the release, even though reading the triggers documentation I had expected this to work.

@webbertakken
Copy link
Member

Trying to fix in #30

@webbertakken
Copy link
Member

Reverted in #31

Rolling next minor version instead.

@webbertakken
Copy link
Member

Still does not work, with the warning This action can only operate on semantically versioned releases, however we probably don't want to publish patch level for a simple action like this.

I also do not see a difference in unity builder's versioning workflow, just that we use a more complicated tag (v2.0-alpha-13) there. Which technically is also not a 3 digit semantic version either.

I believe 2 digit versions are quite common in actions, not sure if we should switch everything to 3 digit semantic versioning.
Any thoughts?

@davidmfinol
Copy link
Member Author

I think we should use 3 digit semantic versioning everywhere, where we leave the patch version as 0 most of the time.

For example, can we try v1.2.0 and see if that works?
If it does, we could have the next release be v1.3.0 and so on.

@webbertakken
Copy link
Member

https://www.npmjs.com/package/semver#user-content-coercion should work for us.

However it is currently only done for prereleases (see here).

To make it work for non-prerelease v[Major].[Minor] and deduce [Patch] we will need this.

Forking the action.

@webbertakken
Copy link
Member

I think we should use 3 digit semantic versioning everywhere, where we leave the patch version as 0 most of the time.

For example, can we try v1.2.0 and see if that works? If it does, we could have the next release be v1.3.0 and so on.

Or that.

@webbertakken
Copy link
Member

Since rule 2 of semantic versioning dictates that a normal version number MUST have three digits, I think your suggestion is better @davidmfinol.

Let's move to full semver for all our repos to solve the problem across the board.

Tagging one additional version to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to resolve action game-ci/steam-deploy@v1, unable to find version v1
2 participants