Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure licenses #202

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Secure licenses #202

merged 1 commit into from
Jan 23, 2021

Conversation

webbertakken
Copy link
Member

Changes

  • Use pull_request_target to run pull request workflow on the workflow of main to be able to use secrets.
  • Move license to secrets
  • Reduce exposure of ENV variables that hold secrets
  • Checkout the code from the PR to run the test builds against
  • Ignore changes in github workflows as it can become rather confusing if you try to change a workflow, when it doesn't trigger on the PR itself, but on main only.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@webbertakken webbertakken merged commit 2cec591 into main Jan 23, 2021
@webbertakken webbertakken deleted the secure-licenses branch January 23, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webbertakken