Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on USYM_UPLOAD_AUTH_TOKEN if defined #234

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Conversation

mastef
Copy link
Contributor

@mastef mastef commented Mar 26, 2021

To automatically upload symbols to unity, we need to define the USYM_UPLOAD_AUTH_TOKEN variable. Currently the build container ignores this variable, even if it's defined in the github action.

2021-03-26T02:35:35.5938747Z time="2021-03-26T02:35:35Z" level=fatal msg="Please provide an auth token with USYM_UPLOAD_AUTH_TOKEN environment variable"

Changes

  • Passes on USYM_UPLOAD_AUTH_TOKEN to the docker process, if it's defined

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (not needed)
  • Tests (not needed)

To automatically upload symbols to unity, we need to define the `USYM_UPLOAD_AUTH_TOKEN` variable. Currently the build container ignores this variable, even if it's defined in the github action.

```
2021-03-26T02:35:35.5938747Z time="2021-03-26T02:35:35Z" level=fatal msg="Please provide an auth token with USYM_UPLOAD_AUTH_TOKEN environment variable"
```
@github-actions
Copy link

Cat Gif

@codecov-io
Copy link

Codecov Report

Merging #234 (86403f9) into main (224f973) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files          19       19           
  Lines         544      544           
  Branches       97       90    -7     
=======================================
  Hits          398      398           
  Misses        145      145           
  Partials        1        1           
Impacted Files Coverage Δ
src/model/docker.ts 21.42% <ø> (ø)

@davidmfinol
Copy link
Member

Do your builds work if you use your mastef:patch-1 branch?
I'm guessing you're setting USYM_UPLOAD_AUTH_TOKEN to a random value?
Do the other options suggested at https://www.debugcn.com/en/article/38100430.html not work for you?

@mastef
Copy link
Contributor Author

mastef commented Mar 26, 2021

Do your builds work if you use your mastef:patch-1 branch?
I'm guessing you're setting USYM_UPLOAD_AUTH_TOKEN to a random value?
Do the other options suggested at https://www.debugcn.com/en/article/38100430.html not work for you?

Hi! The builds work, but it's not using our proper USYM_UPLOAD_AUTH_TOKEN. Ideally the builder should use the USYM_UPLOAD_AUTH_TOKEN that we set in the github actions file, so the USYM gets uploaded to our Unity Dashboard.

@davidmfinol davidmfinol merged commit 4d0b6e6 into game-ci:main Mar 28, 2021
szymon-kazmierczak pushed a commit to zendesk/unity-builder that referenced this pull request Apr 24, 2021
To automatically upload symbols to unity, we need to define the `USYM_UPLOAD_AUTH_TOKEN` variable. Currently the build container ignores this variable, even if it's defined in the github action.

```
2021-03-26T02:35:35.5938747Z time="2021-03-26T02:35:35Z" level=fatal msg="Please provide an auth token with USYM_UPLOAD_AUTH_TOKEN environment variable"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants