Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git private token not being set correctly for https #394

Merged
merged 1 commit into from
May 2, 2022

Conversation

khalid-sani
Copy link
Contributor

Changes

when using gitprivatetoken, the build logs showed an error

warning: ***github.com/.insteadof has multiple values
error: cannot overwrite multiple values with a single value
Use a regexp, --add or --replace-all to change ***github.com/.insteadOf. 

substitution url for https did not work.
this fix would add a value for https instead of overwriting it

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

github-actions bot commented May 1, 2022

Cat Gif

@webbertakken
Copy link
Member

Great!

Could you confirm that this works for you by using game-ci/unity-builder@c847cad57ec982833951d422bc9ec1ddd0ecd9b4?

@codecov-commenter
Copy link

Codecov Report

Merging #394 (c847cad) into main (d066039) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   53.30%   53.30%           
=======================================
  Files          64       64           
  Lines        1994     1994           
  Branches      338      368   +30     
=======================================
  Hits         1063     1063           
+ Misses        927      871   -56     
- Partials        4       60   +56     
Impacted Files Coverage Δ
src/model/input.ts 92.61% <0.00%> (ø)
src/model/docker.ts 17.24% <0.00%> (ø)
src/model/system.ts 86.84% <0.00%> (ø)
src/model/cli/cli.ts 31.34% <0.00%> (ø)
src/model/image-tag.ts 54.44% <0.00%> (ø)
src/model/input-readers/git-repo.ts 47.36% <0.00%> (ø)
src/model/cloud-runner/cloud-runner.ts 79.31% <0.00%> (ø)
src/model/input-readers/action-yaml.ts 36.36% <0.00%> (ø)
src/model/cloud-runner/providers/aws/index.ts 16.66% <0.00%> (ø)
src/model/cloud-runner/providers/k8s/index.ts 12.00% <0.00%> (ø)
... and 12 more

@khalid-sani
Copy link
Contributor Author

khalid-sani commented May 2, 2022

Screenshot 2022-05-02 at 9 47 42 PM

Screenshot 2022-05-02 at 10 10 28 PM

Tested. Works fine.

@webbertakken webbertakken merged commit 4556fc4 into game-ci:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants