Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud runner develop v0.1 #395

Merged
merged 13 commits into from
May 4, 2022
Merged

Cloud runner develop v0.1 #395

merged 13 commits into from
May 4, 2022

Conversation

frostebite
Copy link
Member

@frostebite frostebite commented May 1, 2022

  • Cancel follow logs flag now requires cloudRunnerIntegrationTests flag to avoid accidental triggering
  • Link to AWS Cloud Watch logs fixed
  • Cleanup pipeline now uses AWS list all CLI command which includes info about resource age for monitoring

@github-actions
Copy link

github-actions bot commented May 1, 2022

Cat Gif

@frostebite frostebite self-assigned this May 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #395 (bb93233) into main (4556fc4) will decrease coverage by 0.94%.
The diff coverage is 17.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   53.30%   52.36%   -0.95%     
==========================================
  Files          64       65       +1     
  Lines        1994     2049      +55     
  Branches      368      385      +17     
==========================================
+ Hits         1063     1073      +10     
- Misses        871      914      +43     
- Partials       60       62       +2     
Impacted Files Coverage Δ
src/model/cloud-runner/providers/k8s/index.ts 12.00% <ø> (ø)
...-runner/providers/aws/commands/aws-cli-commands.ts 12.38% <12.69%> (-4.29%) ⬇️
...cloud-runner/services/follow-log-stream-service.ts 17.85% <17.85%> (ø)
...odel/cloud-runner/providers/aws/aws-task-runner.ts 9.00% <20.00%> (+1.50%) ⬆️
...oud-runner/providers/k8s/kubernetes-task-runner.ts 14.54% <25.00%> (ø)
src/model/build-parameters.ts 95.34% <100.00%> (ø)
...iders/aws/cloud-formations/base-stack-formation.ts 100.00% <100.00%> (ø)
.../aws/cloud-formations/task-definition-formation.ts 100.00% <100.00%> (ø)

@frostebite frostebite linked an issue May 1, 2022 that may be closed by this pull request
@frostebite
Copy link
Member Author

Currently the AWS pipelines fail because I deleted the base stack to cleanup and test from scratch.

But this doesn't delete the AWS VPCs it seems, now I have reached the max 5 I can create. And deleting them is blocked because you must first delete dependent resources.

I will work through that shortly and reinitialize the base stack.

@frostebite frostebite marked this pull request as ready for review May 3, 2022 23:17
@frostebite frostebite merged commit f77696e into main May 4, 2022
@frostebite frostebite deleted the cloud-runner-develop branch May 4, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unity Serial Not Being Properly Extracted From Personal License
3 participants