Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Arguments Passed to Unity #623

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Jan 21, 2024

Changes

  • Wrap Unity arguments with quotes to allow for spaces in arguments
  • Fix missing customBuildName parameter for Windows builds
  • Add spaces to build name in build tests
  • Bump action versions in build tests
  • Fix artifact naming for v4

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ba8197) 37.40% compared to head (d4b0fce) 37.40%.

❗ Current head d4b0fce differs from pull request most recent head fdbe53d. Consider uploading reports for the commit fdbe53d to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   37.40%   37.40%           
=======================================
  Files          75       75           
  Lines        3048     3048           
  Branches      605      605           
=======================================
  Hits         1140     1140           
  Misses       1908     1908           

@AndrewKahr AndrewKahr merged commit 2800d14 into main Jan 21, 2024
50 of 52 checks passed
@AndrewKahr AndrewKahr deleted the bug/windows-arguments branch January 21, 2024 10:45
Copy link
Member

@GabLeRoux GabLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍

simon-homa pushed a commit to homagames/unity-builder that referenced this pull request Mar 7, 2024
* Add missing parameter, add quotes around variables, bump action versions

* Wrap quotes

* Fix upload artifact naming conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants