fix(windows): replacing of urls if gitPrivateToken is set #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 36.97% 36.97%
=======================================
Files 77 77
Lines 3121 3121
Branches 645 645
=======================================
Hits 1154 1154
Misses 1824 1824
Partials 143 143 |
homapf
added a commit
to homagames/unity-builder
that referenced
this pull request
Aug 2, 2024
* fix(windows): replacing of urls if gitPrivateToken is set (game-ci#648) * Mac logs to file * Cloud runners stdout log * Also log stderr * Test * Fix stdout * Keep ignoreReturnCode --------- Co-authored-by: Filip Kajzer <filipkajzer@gmail.com>
|
Released in v4.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
set_gitcredential.ps1whereurl.was inside of the string, resulting in errors when buildingwith: gitPrivateTokenRelated Issues
Related PRs
Successful Workflow Run Link
Checklist
code of conduct
in the documentation repo)