Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: can't manage programs in group #58

Merged
merged 7 commits into from
Dec 31, 2018
Merged

Bugfix: can't manage programs in group #58

merged 7 commits into from
Dec 31, 2018

Conversation

inSeek
Copy link
Contributor

@inSeek inSeek commented Dec 30, 2018

for fixing this issue #57

@f9n
Copy link
Contributor

f9n commented Dec 30, 2018

Hi,
Thanks for your merge request. We use the master branch only for release operations.
Can you change the branch to 2.x instead of the master branch?

const Process = ({ node, process, refreshNodes }) => {
  const handleProcess = (action, process) => {
    const nodeName = node.general.name;
    api.processes.process[action](nodeName, `${process.group}:${process.name}`).then(data => {
      console.log(data);
      refreshNodes();
    });
  };
  return (
       ....
          <Button
            color="success"
            onClick={() => handleProcess("start", process)}
          >
            Start
          </Button>{" "}
          <Button
            color="danger"
            onClick={() => handleProcess("stop", process)}
          >
            Stop
          </Button>{" "}
          <Button
            color="warning"
            onClick={() => handleProcess("restart", process)}
          >
            Restart
          </Button>{" "}
          <ProcessLog process={process} node={node} />
      ....
  );
};

@inSeek inSeek changed the base branch from master to 2.x December 31, 2018 05:08
@inSeek
Copy link
Contributor Author

inSeek commented Dec 31, 2018

I saw clear password and other sensitive information of node shows in api response, but seems they would not be used in anywhere? so... I comment them out by security reason... if you don't like it, I can rollback :))

@f9n f9n merged commit 7c80082 into gamegos:2.x Dec 31, 2018
@f9n
Copy link
Contributor

f9n commented Dec 31, 2018

Thanks, I like it :)) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants