Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quantity pairs in calculate_trigger_rate.py #1027

Merged

Conversation

GernotMaier
Copy link
Contributor

@GernotMaier GernotMaier commented Jun 27, 2024

Use the CommandLineParser.parse_quantity_pair for the configuration of viewcone and energy range in calculate_trigger_rate.py.

This comment has been minimized.

@GernotMaier GernotMaier marked this pull request as ready for review June 27, 2024 09:04
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (73.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

Copy link
Collaborator

@VictorBarbosaMartins VictorBarbosaMartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here, thanks.

@GernotMaier GernotMaier merged commit f89a79c into main Jun 29, 2024
11 checks passed
@GernotMaier GernotMaier deleted the quantity-pairs-to-simulate_showers_for_trigger_rates branch June 29, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants