Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust arguments legends_handler #998

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

tobiaskleiner
Copy link
Collaborator

No description provided.

@tobiaskleiner tobiaskleiner changed the title adjust arguments adjust arguments legends_handler Jun 18, 2024

This comment has been minimized.

@tobiaskleiner tobiaskleiner marked this pull request as ready for review June 18, 2024 12:53
Copy link
Contributor

@GernotMaier GernotMaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can you check on the one comment I have. Otherwise ready to merge.

# handlebox is expected, return None if not provided
return None

def legend_artist(_, __, ___, handlebox):
x0, y0 = (
handlebox.xdescent + handlebox.width / 3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is repeated quite frequently. Is there an easy way to avoid it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a function to return the center values.

Copy link

Failed

  • 72.40% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 72.40% Coverage (72.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

@tobiaskleiner tobiaskleiner merged commit 1504c24 into main Jun 20, 2024
8 of 10 checks passed
@tobiaskleiner tobiaskleiner deleted the legend_handler-change-args branch June 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants