Client: offer all supported serializers #270
Conversation
|
ping @gammazero, can you please take a look at this one ? Also I'd like to help with the maintenance of Nexus. I have a bunch of features planned that I'd like to implement |
| @@ -691,7 +691,7 @@ func (ks *serverKeyStore) AuthRole(authid string) (string, error) { | |||
|
|
|||
| func TestConnectContext(t *testing.T) { | |||
| const ( | |||
| expect = "dial tcp: lookup localhost: operation was canceled" | |||
| expect = "dial tcp: operation was canceled" | |||
There was a problem hiding this comment.
I think the better way to fix this is to either change CI to use a later version of go, or have the test look for "operation was canceled"
Right. The authentication API in both the client and server API can be simplified. I have already made some progress on that front, will share the changes I made. |
|
Regarding internal queuing. I believe that are some bottlenecks around concurrency, in my benchmarks, the RPC/second count doesn't gain significantly as the number of goroutines increases. On a single core I could do 40k+ RPC/second (empty payload) but as the concurrency is increased, we can clearly see diminishing returns |
Without changing the user API, takes care of #260
If no serializer is provided in the config: offer all supported
If specific serializer is request, keep the existing behavior