Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completion date to todo_item #52

Closed
ingorichter opened this issue Apr 5, 2017 · 2 comments
Closed

Add completion date to todo_item #52

ingorichter opened this issue Apr 5, 2017 · 2 comments
Labels
enhancement help wanted

Comments

@ingorichter
Copy link
Contributor

Currently the todo_item has a completed field. It would be beneficial for reporting reasons, to have a completed_date or completed_timestamp as part of the todo_item.
@gammons
Copy link
Owner

gammons commented Apr 6, 2017

Yep, I remember asking myself if I should just have a completed date instead of a boolean. I don't remember what the reason was that I chose boolean. Either way, this does make sense.

@ingorichter
Copy link
Contributor Author

I have a PR #53 for it

@gammons gammons closed this as completed Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gammons @ingorichter