Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup rules #107

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Startup rules #107

merged 2 commits into from
Jul 4, 2023

Conversation

curiousdannii
Copy link
Contributor

Implement the new startup sequence (ganelson/inform-evolution#22)

Outstanding errors:

  • StandardValueAdjectives

    Problem__ PM_AdjectiveMisapplied
    --> In the sentence 'if the turn sequence rulebook is empty' (source text, line 81),
    it looks as if you intend 'turn sequence rulebook is empty' to be a
    condition, but that seems to involve applying the adjective 'empty' to a
    nothing based rulebook - and I have no definition of it which would apply
    in that situation. (Try looking it up in the Lexicon part of the Phrasebook
    index to see what definition(s) 'empty' has.)
    I was trying to match this phrase:
    if (turn sequence rulebook is empty - a condition):
    I recognised:
    turn sequence rulebook is empty = a condition
    Problem__ PM_AdjectiveMisapplied
    --> In the sentence 'if the turn sequence rulebook is not empty' (source
    text, line 82), it looks as if you intend 'turn sequence rulebook is not
    empty' to be a condition, but that seems to involve applying the adjective
    'empty' to a nothing based rulebook - and I have no definition of it which
    would apply in that situation. (Try looking it up in the Lexicon part of
    the Phrasebook index to see what definition(s) 'empty' has.)
    I was trying to match this phrase:
    if (turn sequence rulebook is not empty - a condition):
    I recognised:
    turn sequence rulebook is not empty = a condition

    This seems to be caused by a nothing based rulebook not validly matching the definition:

    Definition: a rulebook is empty rather than non-empty if I6 routine "RulebookEmpty" says so (it
    contains no rules, so that following it does nothing and makes no decision).

@curiousdannii
Copy link
Contributor Author

I think a number of tests are failing because of some unexpected line breaks, but I haven't been able to find their cause.

@ganelson ganelson merged commit ef1c799 into ganelson:master Jul 4, 2023
@curiousdannii
Copy link
Contributor Author

This is a diff of the Say-Fonts tests from before and after the startup rules are applied. Somewhere a stray line break is being printed, but I haven't worked out where yet.

https://gist.github.com/curiousdannii/c4d854004d1aa9cd6b2a7d2abb82e637/revisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants