Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compilable fonts from Styles panel as well as local and native fonts #13

Closed
DamirPecnik opened this issue Mar 28, 2015 · 5 comments
Milestone

Comments

@DamirPecnik
Copy link
Contributor

I was trying to set Font for Header but only was getting family word to css. See screenshot.

2015-03-28 23 04 18

@w00fz
Copy link
Member

w00fz commented Mar 28, 2015

Like said in #10 we are planning to add support in hydrogen for the font picker. It didn't make it through beta1.
Your implementation is almost right but you are missing a few bits. Because it's remote you need the url() and because it's Google fonts you need the pretending google fonts url

@w00fz
Copy link
Member

w00fz commented Mar 28, 2015

Sorry phone submitted before I was done :)
url(http://fonts.googleapis.com/css?$header-font)

Something along those lines.

@DamirPecnik
Copy link
Contributor Author

Thanks for the input.

@w00fz
Copy link
Member

w00fz commented Mar 30, 2015

We discussed the font picker and know it isn't completed but I think we have a good plan now.
In short, we are going to add support for local fonts as well as google fonts so the font picker field itself could be populated similar to the way you write it in CSS.

As font stack: "Helvetica", "Times New Roman", sans-serif
As google: family=Ubuntu...
As single font: Helvetica

You will be able to define local fonts from the theme.yaml in a key value definition that sort of looks like roboto: 'gantry-theme://fonts/roboto_regular_macroman/Roboto-Regular-webfont' and if you wanted to use it you would just reference roboto in the field.

This is the plan, it's going to take a bit of time to get it all together but at least you get the idea :)

@DamirPecnik
Copy link
Contributor Author

Awesome!

@w00fz w00fz added this to the Beta 3 milestone Apr 1, 2015
@w00fz w00fz modified the milestones: Beta 4, Beta 3, Beta 5 Apr 17, 2015
mahagr added a commit that referenced this issue Apr 30, 2015
mahagr added a commit that referenced this issue May 1, 2015
@mahagr mahagr closed this as completed in 1cbd162 May 1, 2015
@w00fz w00fz changed the title input.fonts doesn't work Add support for compilable fonts from Styles panel as well as local and native fonts May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants