Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multiple top-level packages error #128

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Fix Multiple top-level packages error #128

merged 1 commit into from
Jan 14, 2023

Conversation

CMurtagh-LGTM
Copy link
Contributor

Installing the python package via pip install . was giving me the error Multiple top-level packages discovered in a flat-layout: ['tst', 'etc', 'gap', 'demos']..

Here are the versions my things

❯ python --version
Python 3.10.8
❯ pip --version
pip 22.3.1 from /usr/lib/python3.10/site-packages/pip (python 3.10)
❯ pip show setuptools
Name: setuptools
Version: 65.2.0
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email: distutils-sig@python.org
License:
Location: /usr/lib/python3.10/site-packages
Requires: appdirs, jaraco.text, more-itertools, ordered-set, packaging, pyparsing, tomli, validate-pyproject
Required-by: jupyter_packaging

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #128 (fa7846e) into master (518a8a6) will increase coverage by 17.52%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #128       +/-   ##
===========================================
+ Coverage    8.95%   26.47%   +17.52%     
===========================================
  Files           8       14        +6     
  Lines         715      865      +150     
===========================================
+ Hits           64      229      +165     
+ Misses        651      636       -15     
Impacted Files Coverage Δ
gap/JupyterUtil.gd 100.00% <0.00%> (ø)
gap/JupyterStream.gd 100.00% <0.00%> (ø)
gap/JupyterHelp.gd 100.00% <0.00%> (ø)
gap/JupyterRenderable.gd 100.00% <0.00%> (ø)
gap/JupyterKernel.gd 100.00% <0.00%> (ø)
gap/JupyterMsg.gd 100.00% <0.00%> (ø)
gap/JupyterCompletion.gi 90.00% <0.00%> (+0.52%) ⬆️
gap/JupyterInspection.gi 71.83% <0.00%> (+2.71%) ⬆️
gap/JupyterKernel.gi 8.61% <0.00%> (+8.61%) ⬆️
gap/JupyterHelp.gi 8.64% <0.00%> (+8.64%) ⬆️
... and 4 more

@olexandr-konovalov
Copy link
Member

Thanks @CMurtagh-LGTM! @ZachNewbery does this look good to you?

@ZachNewbery
Copy link
Collaborator

ZachNewbery commented Dec 13, 2022 via email

@olexandr-konovalov olexandr-konovalov requested review from ZachNewbery and removed request for ZachNewbery January 13, 2023 10:42
@ZachNewbery
Copy link
Collaborator

ZachNewbery commented Jan 13, 2023

CI failure about io not being available - I don't think that's caused by these changes

@ZachNewbery ZachNewbery merged commit 0870f9c into gap-packages:master Jan 14, 2023
@olexandr-konovalov
Copy link
Member

CI passes in the main branch - not testing under GAP 4.9 anymore. Thanks both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants