New buildsystem based on gac #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah well, it turns out that gac does not manage to link C++ kernel extensions in GAP 4.9 and 4.10, so I guess this PR is out of play. Anyway, perhaps can be revisited in the future. |
|
Thanks for this, but it conflicts with the other PR I just merged (sorry if I should have looked at them the other way around) |
fingolfin
force-pushed
the
mh/buildsys
branch
2 times, most recently
from
fe82659
to
8073d87
Compare
Stop using autotools, and instead start to use Makefile.gappkg (see <gap-system/gap#3683>); this has several advantages, e.g. running configure is much quicker (esp. on macOS and Windows), it automatically rebuilds if GAP changed (detected via changes to GAP's sysinfo.gap), and of course there is no need for autoconf, automake, autogen.sh etc., nor need to deal with M4 syntax in cryptic configure.ac scripts
fingolfin
force-pushed
the
mh/buildsys
branch
from
8073d87
to
34d0def
Compare
|
@ChrisJefferson no worries. I actually thought this PR was hopelessly flawed and would not work in GAP 4.10, due to the use of C++ code, but I figured out a trivial fix (namely adding So I've now rebased this, and it seems to work well, at least locally for me and on Travis. See also gap-packages/json#16 where I made a similar change. |
fingolfin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using autotools, and instead start to use Makefile.gappkg (see gap-system/gap#3683); this has several advantages, e.g. running configure is much quicker (esp. on macOS and Windows), it automatically rebuilds if GAP changed (detected via changes to GAP's sysinfo.gap), and of course there is no need for autoconf, automake, autogen.sh etc., nor need to deal with M4 syntax in cryptic configure.ac scripts